linux-kernel - [tip:sched/urgent] cpuset: Check if the cpus allowed is a subset of the cpuset's cpus for PF_THREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2009 00:06:26 GMT
From:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, vatsa@...ux.vnet.ibm.com,
	hpa@...or.com, mingo@...hat.com, dhaval@...ux.vnet.ibm.com,
	balbir@...ibm.com, akpm@...ux-foundation.org, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:sched/urgent] cpuset: Check if the cpus allowed is a subset of the cpuset's cpus for PF_THREAD_BOUND threads

Commit-ID:  5a98d36112f4301f068b638d6e0db2357f7deb75
Gitweb:     http://git.kernel.org/tip/5a98d36112f4301f068b638d6e0db2357f7deb75
Author:     Dhaval Giani <dhaval@...ux.vnet.ibm.com>
AuthorDate: Thu, 12 Mar 2009 23:15:01 +0530
Commit:     Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 13 Mar 2009 00:21:25 +0100

cpuset: Check if the cpus allowed is a subset of the cpuset's cpus for PF_THREAD_BOUND threads

When a kernel thread which has been bound to a CPU is moved to
a cpuset which is a superset of the CPU it is bound to, the
movement fails.

 [root@...11 cgroups]# mkdir a
 [root@...11 cgroups]# echo 3 > a/cpuset.cpus
 [root@...11 cgroups]# echo 0 > a/cpuset.mems
 [root@...11 cgroups]# echo 12 > a/tasks
 [root@...11 cgroups]# echo 12 > tasks
 -bash: echo: write error: Invalid argument
 [root@...11 cgroups]# cat cpuset.cpus
 0-7
 [root@...11 cgroups]#

(pid 12 is the migration thread bound to CPU 3)

Change the check to see if the cpus allowed is a subset of the
cpus allowed for that cpuset.

Signed-off-by: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
Cc: Balbir Singh <balbir@...ibm.com>
Cc: Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: menage@...gle.com
LKML-Reference: <20090312174501.GA7821@...ux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/cpuset.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index f76db9d..34cfd46 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1362,7 +1362,7 @@ static int cpuset_can_attach(struct cgroup_subsys *ss,
 
 	if (tsk->flags & PF_THREAD_BOUND) {
 		mutex_lock(&callback_mutex);
-		if (!cpumask_equal(&tsk->cpus_allowed, cs->cpus_allowed))
+		if (!cpumask_subset(&tsk->cpus_allowed, cs->cpus_allowed))
 			ret = -EINVAL;
 		mutex_unlock(&callback_mutex);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/