linux-kernel - Re: kernel_thread() usage found in staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2009 14:24:28 -0700
From:	Greg KH <greg@...ah.com>
To:	Peter Teoh <htmldeveloper@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: kernel_thread() usage found in staging

On Fri, Mar 13, 2009 at 04:26:27PM +0800, Peter Teoh wrote:
> >From Documentation/feature_removal_schedule.txt, it is well-known that
> kernel_thread() API usage is discouraged, but in staging we still
> routinely see its use.   Perhaps the original driver owner have
> overlooked this?

Yes, they probably didn't realize this and some of this code predates
the kthread code.

> ./rt2870/common/2870_rtmp_init.c:
> 	pid_number = kernel_thread(MlmeThread, pAd, CLONE_VM);
> 	pid_number = kernel_thread(RTUSBCmdThread, pAd, CLONE_VM);
> 	pid_number = kernel_thread(TimerQThread, pAd, CLONE_VM);
> 
> ./usbip/usbip_common.c:
> 	retval = kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0);
> 	retval = kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
> 
> ./usbip/usbip_event.c:
> 	kernel_thread(usbip_thread, (void *)eh, 0);
> 
> ./epl/ShbIpc-LinuxKernel.c:
> 	    kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
> 	    kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
> 
> ./epl/EplSdoUdpu.c:
> 	    kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);

Patches are gladly accepted to clean this up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/