linux-kernel - Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2009 14:08:45 -0700
From:	David Brownell <david-b@...bell.net>
To:	Purushotam Kumar <purushotam@...com>
Cc:	davinci-linux-open-source@...ux.davincidsp.com,
	linux-kernel@...r.kernel.org, drzeus-mmc@...eus.cx
Subject: Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.

I noticed a newish bug in probe() ...

On Monday 16 March 2009, Purushotam Kumar wrote:
> +       if (!pdata || pdata->wires == 4 || pdata->wires == 0)
> +               mmc->caps |= MMC_CAP_4_BIT_DATA;

So pdata may be null.  But, if it is, then ...

> +
> +       mmc->ops = &mmc_davinci_ops;
> +       mmc->f_min = 312500;
> +       mmc->f_max = 25000000;
> +       if (pdata->max_freq)
> +               mmc->f_max = pdata->max_freq;

Oops!

> +       if (pdata->caps)
> +               mmc->caps |= pdata->caps;

Double oops!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/