linux-kernel - Re: [git-pull -tip] x86: cleanup code changing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2009 14:25:18 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git-pull -tip] x86: cleanup code changing

On Tue, 17 Mar 2009, Jaswinder Singh Rajput wrote:

> The following changes since commit 1f31834fbbb8de367914f044d3268c6afbfdd783:
>   Ingo Molnar (1):
>         Merge branch 'x86/mce2'
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-cpu.git master
> 
> Jaswinder Singh Rajput (2):
>       x86: cpu/intel.c cleanup
>       x86: mpparse cleanup

I asked for separate patches which do mechanical cleanup and
structural code changes. Just seperating intel.c and mpparse.c patches
from the others is _NOT_ what I asked for.

The include reordering, #ifdef annotation and random changes of white
space and comments have absolutely nothing to do with the structural
changes in the code.

So what we want is: 
   one patch doing mechanical cleanups
   patch(es) which change the code flow

   for the code flow changes we want one patch per modification: e.g:

   P1: simplify A
   P2: simplify B
   ...

That way the mechanical cleanups can be verified as zero changes and
the patches which change the code flow are small and can be reviewed
easily.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/