linux-kernel - Re: [PATCH] Block - Honour barrier requests in loop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2009 15:09:05 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Nikanth Karthikesan <knikanth@...e.de>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Christoph Hellwig <hch@...radead.org>,
	Gerd Hoffmann <kraxel@...hat.com>,
	Constantine Sapuntzakis <csapuntz@...il.com>,
	Miklos Szeredi <miklos@...redi.hu>, nikanth@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Block - Honour barrier requests in loop driver

On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote:
> +			if (!file->f_op || !file->f_op->fsync) {
> +				ret = -EOPNOTSUPP;
> +				goto out;
> +			}

file->f_op is never zero, so you can remove the checks for that.
Otherwise looks good.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/