linux-kernel - [patch] one extra (incorrect) test in mask_ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2009 19:16:46 -0700
From:	Frank Rowand <frank.rowand@...sony.com>
To:	mingo@...hat.com
CC:	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [patch] one extra (incorrect) test in mask_ack_irq()


preempt-irqs-core.patch added an incorrect check for the existence of
desc->chip->ack to mask_ack_irq()

Signed-off-by: Frank Rowand <frank.rowand@...sony.com>

--- linux-2.6.29-rc7/kernel/irq/chip.c	2009-03-18 17:58:03.000000000 -0800
+++ linux-2.6.29-rc7_new/kernel/irq/chip.c	2009-03-18 17:59:15.000000000 -0800
@@ -293,7 +293,6 @@ static inline void mask_ack_irq(struct i
 	if (desc->chip->mask_ack)
 		desc->chip->mask_ack(irq);
 	else {
-		if (desc->chip->ack)
 		if (desc->chip->mask)
 			desc->chip->mask(irq);
 		if (desc->chip->ack)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/