linux-kernel - Re: [PATCH] Add SELinux context and TTY name to AUDIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2009 16:58:10 -0400
From:	Paul Moore <paul.moore@...com>
To:	linux-audit@...hat.com
Cc:	Miloslav Trmac <mitr@...hat.com>, viro <viro@...iv.linux.org.uk>,
	Eric Paris <eparis@...hat.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records

On Thursday 19 March 2009 01:18:00 pm Miloslav Trmac wrote:
> From: Miloslav Trmač <mitr@...hat.com>
>
> Add SELinux context information and TTY name (consistent with the
> AUDIT_SYSCALL record) to AUDIT_TTY.  An example record after applying
> this patch:
>
>  type=TTY msg=audit(1237480806.220:22): tty pid=2601 uid=0 auid=500 ses=1
>  subj=unconfined_u:unconfined_r:unconfined_t:s0 major=136 minor=1 tty=pts1
>  comm="bash" data=6361740D
>
> (line wrapped, new fields are "subj" and "tty".)
>
> Signed-off-by: Miloslav Trmač <mitr@...hat.com>
> ---
>  drivers/char/tty_audit.c |   57 ++++++++++++++++++++++++-------------
>  1 file changed, 38 insertions(+), 19 deletions(-)

Just a quick procedural comment, in the future you should include patches in 
the body of the email; people will likely ignore your submission otherwise.

There are several audit experts which should review this code but two things 
jumped out at me when glancing at your patch:

 1. SELinux SIDs should not be recorded
 2. From a SELinux/security point of view ttys are considered objects
    and their labels/contexts should be recorded with "obj=" not "subj="

-- 
paul moore
linux @ hp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/