linux-kernel - bug in drivers/edac/edac_core.h pci_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Mar 2009 16:54:01 -0700
From:	"Jeff Haran" <jharan@...cade.COM>
To:	<linux-kernel@...r.kernel.org>
Subject: bug in drivers/edac/edac_core.h pci_write_bits32()

2.6.29 and previous versions seem to contain this bug which I found just
eyeballing the code:

static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
                    u32 value, u32 mask)
{
    if (mask != 0xffff) {
        u32 buf;

        pci_read_config_dword(pdev, offset, &buf);
        value &= mask;
        buf &= ~mask;
        value |= buf;
    }

    pci_write_config_dword(pdev, offset, value);
}

I'm pretty sure that "if" statement should be:

	if (mask != 0xffffffff) {

Please copy my email address in any response as I do not subscribe.

Thanks,

Jeff Haran
Brocade
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/