linux-kernel - Re: [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation entry copying. -- makes X hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Mar 2009 12:00:11 +0200
From:	Florian Mickler <florian@...kler.org>
To:	Eric Anholt <eric@...olt.net>
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.sourceforge.net,
	keithp@...thp.com
Subject: Re: [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation
 entry copying. -- makes X hang

Hi!

On Wed, 25 Mar 2009 14:45:10 -0700
Eric Anholt <eric@...olt.net> wrote:

> Signed-off-by: Eric Anholt <eric@...olt.net>
> Reviewed-by: Keith Packard <keithp@...thp.com>
> ---
>  drivers/gpu/drm/i915/i915_gem.c |  187
> +++++++++++++++++++++++++++----------- 1 files changed, 133
> insertions(+), 54 deletions(-)
> 

I testet Linus' Git tree @ 5d80f8e5a (merge
net-2.6) and discovered that X hung after starting up gdm.

When i start gdm the screen is frozen and X hangs. 
I was able to bisect it down to 

40a5f0decdf050785ebd62b36ad48c869ee4b384 drm/i915: Fix lock order
reversal in GEM relocation entry copying.


when hung /proc/[xpid]/stack did contain:

[<ffffffff8024c13e>] msleep_interruptible+0x2e/0x40
[<ffffffff80557fdd>] i915_wait_ring+0x17d/0x1d0
[<ffffffff8056280d>] i915_gem_execbuffer+0xd2d/0xf70
[<ffffffff80546555>] drm_ioctl+0x1f5/0x320
[<ffffffff802d8ce5>] vfs_ioctl+0x85/0xa0
[<ffffffff802d8f0b>] do_vfs_ioctl+0x20b/0x510
[<ffffffff802d9297>] sys_ioctl+0x87/0xa0
[<ffffffff8020ba8b>] system_call_fastpath+0x16/0x1b
[<ffffffffffffffff>] 0xffffffffffffffff


I reverted that commit now on top of 5d80f8e5a and all 's well .


My X-Stack is from Git at around 20th march. I will update that now,
but as it hangs in a kernel syscall, it shouldn't matter?

Sincerely,

Florian

p.s. no kms 


Download attachment "config.gz" of type "application/x-gzip" (15772 bytes)