lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Mar 2009 16:45:23 +1100 From: Paul Mackerras <paulus@...ba.org> To: Peter Zijlstra <a.p.zijlstra@...llo.nl> Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 01/15] perf_counter: unify and fix delayed counter wakeup Peter Zijlstra writes: > +void perf_counter_wakeup(struct perf_counter *counter) > +{ > + struct perf_mmap_data *data; > + > + rcu_read_lock(); > + data = rcu_dereference(counter->data); > + if (data) { > + (void)atomic_xchg(&data->wakeup, POLL_IN); Really just a nit, but how is this atomic_xchg any different from atomic_set(&data->wakeup, POLL_IN) aside from being slower? Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists