linux-kernel - Re: [PATCH 29/58] move omap24xxcam's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Apr 2009 10:28:30 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	sakari.ailus@...well.research.nokia.com
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Trilok Soni <soni.trilok@...il.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Mauro Carvalho Chehab <mchehab@...hat.com>
Subject: Re: [PATCH 29/58] move omap24xxcam's probe function to
	.devinit.text

Hallo Sakari,

On Wed, Apr 01, 2009 at 10:40:15AM +0300, Sakari Ailus wrote:
> ext Uwe Kleine-König wrote:
>> A pointer to omap24xxcam_probe is passed to the core via
>> platform_driver_register and so the function must not disappear when the
>> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
>> unbinding and binding a device to the driver via sysfs will result in an
>> oops as does a device being registered late.
>>
>> An alternative to this patch is using platform_driver_probe instead of
>> platform_driver_register plus removing the pointer to the probe function
>> from the struct platform_driver.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Cc: Sakari Ailus <sakari.ailus@...ia.com>
>> Cc: Trilok Soni <soni.trilok@...il.com>
>> Cc: Hans Verkuil <hverkuil@...all.nl>
>> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> ---
>>  drivers/media/video/omap24xxcam.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Signed-off-by: Sakari Ailus <sakari.ailus@...well.research.nokia.com>
Does your S-o-b means you care for inclusion in mainline?[1]  Or should
I record that as an Acked-by?

Best regards
Uwe

[1] Quoting Documentation/SubmittingPatches:
	"The Signed-off-by: tag indicates that the signer was involved
	in the development of the patch, or that he/she was in the
	patch's delivery path.

	If a person was not directly involved in the preparation or
	handling of a patch but wishes to signify and record their
	approval of it then they can arrange to have an Acked-by: line
	added to the patch's changelog."
-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/