linux-kernel - Inverted NUMA test in setup_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Mar 2009 22:31:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
CC:	linux-kernel@...r.kernel.org
Subject: Inverted NUMA test in setup_pcpu_remap()?

The test currently is:

	if (!cpu_has_pse || pcpu_need_numa())
		return -EINVAL;

Don't we really mean "!pcpu_need_numa()"?

The way I read the intent, setup_pcpu_remap() should be used in the
NUMA case.  But that's not what's happening because of how this test
is coded.

In fact, the test here is identical to the one used in
setup_pcpu_embed()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/