linux-kernel - Re: [PATCH] nfs: fix nfs_parse_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Apr 2009 09:25:48 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Tom Talpey <tmtalpey@...il.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Yinghai Lu <yinghai@...nel.org>,
	David Miller <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	chuck.lever@...cle.com
Subject: Re: [PATCH] nfs: fix nfs_parse_mount_options() double kfree()

On Fri, 2009-04-03 at 15:07 +0200, Ingo Molnar wrote:
> * Tom Talpey <tmtalpey@...il.com> wrote:
> 
> > At 03:16 AM 4/3/2009, Ingo Molnar wrote:
> > >
> > >Impact: fix crash
> > >
> > >Yinghai Lu reported the following crash:
> > 
> > This has to have been a merge problem, I moved a single kfree() 
> > down a few lines in order to use the pointer in a second context. 
> > With the moved line, it had been running successfully in Trond's 
> > tree and linux-next for several weeks.
> 
> Maybe the tree got rebased and that introduced this merge artifact? 

No, but the linux-next tree also contained cachefs, which hasn't been
merged yet. Let's keep an eye out when it does...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/