linux-kernel - Re: 2.6.29 git, resume from ram broken on thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Apr 2009 19:32:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arkadiusz Miskiewicz <a.miskiewicz@...il.com>,
	Tejun Heo <tj@...nel.org>,
	Arjan van de Ven <arjan@...radead.org>
Cc:	Chris Wright <chrisw@...s-sol.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	Mike Travis <travis@....com>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	virtualization@...ts.osdl.org, xen-devel@...ts.xensource.com,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: 2.6.29 git, resume from ram broken on thinkpad


* Arkadiusz Miskiewicz <a.miskiewicz@...il.com> wrote:

> On Friday 03 of April 2009, Chris Wright wrote:
> > * Arkadiusz Miskiewicz (a.miskiewicz@...il.com) wrote:
> > > What about 9ea09af3bd3090e8349ca2899ca2011bd94cda85 ?
> > >
> > > stop_machine: introduce stop_machine_create/destroy.
> >
> > That is later fixed in a0e280e0f33f6c859a235fb69a875ed8f3420388.
> >
> > Can you please verify if 2.6.29 works for you? 
> 
> I think that the guilty part is 
> CONFIG_CC_STACKPROTECTOR_ALL=y
> CONFIG_CC_STACKPROTECTOR=y

aha!!

> Disabling stackprotector makes problem go away (and my build of 
> final 2.6.29 had it disabled while later builds got it enabled at 
> some moment).

Thanks a ton for that info. Could you try:

   http://people.redhat.com/mingo/tip.git/README

with stack-protector re-enabled please? This fix:

  1f23b77: x86: disable stack-protector for __restore_processor_state()

might do the trick!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/