linux-kernel - Re: [PATCH 2/4] CacheFiles: Revert the addition of write_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 4 Apr 2009 16:55:42 +1100
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	David Howells <dhowells@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>, nfsv4@...ux-nfs.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/4] CacheFiles: Revert the addition of write_one_page()

On Saturday 04 April 2009 00:53:29 David Howells wrote:
> Christoph Hellwig <hch@...radead.org> wrote:
> 
> > Note that in the patch series going into mainline eventually this should
> > not be a separate patch but the new ops should never be introduced.
> 
> Yes, probably, but this makes it easier for people to see what I'm proposing
> to change.

Definitely yes please. kmap resources are not infinite but there is obviously
a proper kmap allocator so long as you only kmap one page at a time, then
others will just block waiting for more. On sane platforms of course there
is no penalty at all.

So this change is definitely required if you want to get this patchset in.
The alternative is to come up with a new API and get that merged first, but
I figure you don't want that kind of dependency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/