[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 04 Apr 2009 12:39:46 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Yinghai Lu <yinghai@...nel.org>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
Arjan van de Ven <arjan@...radead.org>,
Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] x86: make mtrr code could use debugpat
On Sat, 2009-04-04 at 12:22 +0530, Jaswinder Singh Rajput wrote:
> On Sat, 2009-04-04 at 03:18 +0200, Ingo Molnar wrote:
> > * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> >
> > > On Fri, 3 Apr 2009, Yinghai Lu wrote:
> > > >
> > > > only print out get_mtrr when debugpat
> > >
> > > Is that get_mtrr message really so interesting that it needs to be
> > > printed out at all? Even with debugpat?
> >
> > With debugpat it's probably interesting - i think only a very small
> > fraction of users will enable it, and if they do we really want to
> > track all MTRR state.
> >
> > Since old MTRR state gets destroyed by new settings we better have a
> > clear idea how the BIOS set it, that might give us clues about
> > quirks, etc.
> >
> > Based on MTRR bugreport patterns i was the one who asked Yinghai
> > during the development cycle to add more debugging there - so i'm to
> > blame for those printouts. We had several cases where it would have
> > been useful had we known the precise history of MTRR settings.
> >
> > I was under the impression that KERN_DEBUG would only show up on the
> > console if 'debug' is passed in on the boot command line - but your
> > bootlog didnt have 'debug' in it and i guess having it so frequently
> > in the dmesg is confusing as well. It might even be there for every
> > Xorg startup.
> >
>
> If you still want to debug it, use some special parameters at command
> line to avoid annoyance to others.
>
> These debug messages really screwed up my life from last month.
>
If you surprise how these debug messages screwed up my life, so here is
some clues:
1. I pointed to remove or suppress these messages and Ingo, Andrew and
then later on Thomas become upset with me.
2. And because of their upset, I need to delete more than 100 of my
patches and delete many development trees in last few weeks.
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists