linux-kernel - Re: [PATCH] vga16fb: fix color component length for pseudocolor modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 4 Apr 2009 13:03:31 +0200
From:	Krzysztof Helt <krzysztof.h1@...zta.fm>
To:	spock@...too.org
Cc:	linux-kernel@...r.kernel.org,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH] vga16fb: fix color component length for pseudocolor
 modes

On Thu, 2 Apr 2009 14:26:13 +0200
Michal Januszewski <spock@...too.org> wrote:

> vga16fb incorrectly sets the length of the color fields to 6 or 2 bits
> for PSEUDOCOLOR modes, for which either 8 or 4 bits are used per pixel.
> Fix this by setting the length to 8 or 4, respectively.
> 
> Signed-off-by: Michal Januszewski <spock@...too.org>
> ---

Acked-by: Krzysztof Helt <krzysztof.h1@...pl>


> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 5b29389..8f1eb7f 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -506,7 +506,7 @@ static int vga16fb_check_var(struct fb_var_screeninfo *var,
>  	var->red.offset = var->green.offset = var->blue.offset = 
>  	var->transp.offset = 0;
>  	var->red.length = var->green.length = var->blue.length =
> -		(par->isVGA) ? 6 : 2;
> +		(par->isVGA) ? 8 : 4;
>  	var->transp.length = 0;
>  	var->activate = FB_ACTIVATE_NOW;
>  	var->height = -1;
> @@ -1324,7 +1324,7 @@ static int __init vga16fb_probe(struct platform_device *dev)
>  	par->palette_blanked = 0;
>  	par->vesa_blanked = 0;
>  
> -	i = par->isVGA? 6 : 2;
> +	i = par->isVGA? 8 : 4;
>  	
>  	vga16fb_defined.red.length   = i;
>  	vga16fb_defined.green.length = i;
> 

----------------------------------------------------------------------
Kredyt z doplata, nawet 200 000 zl. Sprawdz!
http://link.interia.pl/f20fc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/