linux-kernel - Re: [PATCH 34/56] nfs: Remove void casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Apr 2009 11:14:14 +0100
From:	Jack Stone <jwjstone@...tmail.fm>
To:	linux-kernel@...r.kernel.org
CC:	jeff@...zik.org, kernel-janitors@...r.kernel.org,
	Trond.Myklebust@...app.com
Subject: Re: [PATCH 34/56] nfs: Remove void casts

[Added maintainer CC]
Jack Stone wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@...tmail.fm>
> ---
>  fs/nfs/inode.c   |    2 +-
>  fs/nfs/nfs2xdr.c |    2 +-
>  fs/nfs/nfs3xdr.c |    2 +-
>  fs/nfs/nfs4xdr.c |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index 64f8719..c6aceaf 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -1342,7 +1342,7 @@ void nfs4_clear_inode(struct inode *inode)
>  struct inode *nfs_alloc_inode(struct super_block *sb)
>  {
>  	struct nfs_inode *nfsi;
> -	nfsi = (struct nfs_inode *)kmem_cache_alloc(nfs_inode_cachep, GFP_KERNEL);
> +	nfsi = kmem_cache_alloc(nfs_inode_cachep, GFP_KERNEL);
>  	if (!nfsi)
>  		return NULL;
>  	nfsi->flags = 0UL;
> diff --git a/fs/nfs/nfs2xdr.c b/fs/nfs/nfs2xdr.c
> index c862c93..a9017a6 100644
> --- a/fs/nfs/nfs2xdr.c
> +++ b/fs/nfs/nfs2xdr.c
> @@ -627,7 +627,7 @@ nfs_xdr_readlinkres(struct rpc_rqst *req, __be32 *p, void *dummy)
>  	}
>  
>  	/* NULL terminate the string we got */
> -	kaddr = (char *)kmap_atomic(rcvbuf->pages[0], KM_USER0);
> +	kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0);
>  	kaddr[len+rcvbuf->page_base] = '\0';
>  	kunmap_atomic(kaddr, KM_USER0);
>  	return 0;
> diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c
> index e6a1932..48ccc17 100644
> --- a/fs/nfs/nfs3xdr.c
> +++ b/fs/nfs/nfs3xdr.c
> @@ -859,7 +859,7 @@ nfs3_xdr_readlinkres(struct rpc_rqst *req, __be32 *p, struct nfs_fattr *fattr)
>  	}
>  
>  	/* NULL terminate the string we got */
> -	kaddr = (char*)kmap_atomic(rcvbuf->pages[0], KM_USER0);
> +	kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0);
>  	kaddr[len+rcvbuf->page_base] = '\0';
>  	kunmap_atomic(kaddr, KM_USER0);
>  	return 0;
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 1690f0e..a283caa 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -3565,7 +3565,7 @@ static int decode_readlink(struct xdr_stream *xdr, struct rpc_rqst *req)
>  	 * and and null-terminate the text (the VFS expects
>  	 * null-termination).
>  	 */
> -	kaddr = (char *)kmap_atomic(rcvbuf->pages[0], KM_USER0);
> +	kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0);
>  	kaddr[len+rcvbuf->page_base] = '\0';
>  	kunmap_atomic(kaddr, KM_USER0);
>  	return 0;
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/