linux-kernel - Re: [PATCH 1/1] Document get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Apr 2009 12:27:18 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andy Grover <andy.grover@...cle.com>,
	linux-kernel@...r.kernel.org, mingo@...hat.com, npiggin@...e.de
Subject: Re: [PATCH 1/1] Document get_user_pages_fast()

> > There is one problem.
> > gup and get_page() don't provide any page pinning.
> > 
> > get_page() only gurantee not freed. but don't gurantee to prevent page
> > reclaim
> 
> is_page_cache_freeable() measures page_count()...

sorry, my explanation was too short. 

reclaim can unmap the page. but page migration assume unmap successing mean
page migratable, then user-address associate another page and lost writing data
to old page.

IOW

     CPU0              CPU1                 note
------------------------------------------------------
    gup()
                    page-migration         user-address attach another page
 write data to                             write to old page.
 gup()ed page                              userland can't see it.

   put_page()                              free old page.


> 
> > and Cow change owner process.
> 
> hm.  buggy userspace? Why is that a problem from a kernel perspective?

We already started to discuttion in "[PATCH] fork vs gup(-fast) fix" thread.
but this is very difficult problem. it is still in progress ;)



> > Yes, current all gup caller have serious bug. especially direct-io, aio, bio
> > are broken.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/