linux-kernel - Re: [PATCH 07/14] DRBD: internal_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Apr 2009 09:18:21 +0200
From:	Bart Van Assche <bart.vanassche@...il.com>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <jens.axboe@...cle.com>,
	Greg KH <gregkh@...e.de>, Neil Brown <neilb@...e.de>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Andi Kleen <andi@...stfloor.org>,
	Sam Ravnborg <sam@...nborg.org>, Dave Jones <davej@...hat.com>,
	Nikanth Karthikesan <knikanth@...e.de>,
	Lars Marowsky-Bree <lmb@...e.de>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Lars Ellenberg <lars.ellenberg@...bit.com>
Subject: Re: [PATCH 07/14] DRBD: internal_data_structures

> +static inline void drbd_kobject_uevent(struct drbd_conf *mdev)
> +{
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,10)
> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,15)
> +       kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE, NULL);
> +#else
> +       kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE);
> +       /* rhel4 / sles9 and older don't have this at all,
> +        * which means user space (udev) won't get events about possible changes of
> +        * corresponding resource + disk names after the initial drbd minor creation.
> +        */
> +#endif
> +#endif
> +}

There exist scripts which accept a kernel patch and a kernel version
and remove all code that does not apply to the specified kernel
version. Maybe it's a good idea to run the DRBD code through such a
script before posting it for review.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/