linux-kernel - RE: [PATCH] Input: ad7877.c and ad7879.c: Remove depreciated IRQF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2009 11:57:58 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	<dmitry.torokhov@...il.com>
CC:	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Robin Getz" <rgetz@...ckfin.uclinux.org>
Subject: RE: [PATCH] Input: ad7877.c and ad7879.c: Remove depreciated IRQF_SAMPLE_RANDOM flag

From: Michael Hennerich <michael.hennerich@...log.com>

Dmitry,

Please ignore my last email.
 
This patch removes depreciated IRQF_SAMPLE_RANDOM flags from drivers
currently queued in Dmitry's input subsystem tree. 

Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>

---
 drivers/input/touchscreen/ad7877.c |    4 ++--                       
 drivers/input/touchscreen/ad7879.c |    3 +--                        
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/ad7877.c
b/drivers/input/touchscreen/ad7877.c
index 047bb57..dae7357 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -739,8 +739,8 @@ static int __devinit ad7877_probe(struct spi_device
*spi)
 
 	/* Request AD7877 /DAV GPIO interrupt */
 
-	err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING |
-			IRQF_SAMPLE_RANDOM, spi->dev.driver->name, ts);
+	err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING,
+			spi->dev.driver->name, ts);
 	if (err) {
 		dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
 		goto err_free_mem;
diff --git a/drivers/input/touchscreen/ad7879.c
b/drivers/input/touchscreen/ad7879.c
index 59fad2f..2eb40ee 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -448,8 +448,7 @@ static int __devinit ad7879_construct(bus_device
*bus, struct ad7879 *ts)
 	ad7879_setup(ts);
 
 	err = request_irq(bus->irq, ad7879_irq,
-			  IRQF_TRIGGER_FALLING | IRQF_SAMPLE_RANDOM,
-			  bus->dev.driver->name, ts);
+			  IRQF_TRIGGER_FALLING, bus->dev.driver->name,
ts);
 
 	if (err) {
 		dev_err(&bus->dev, "irq %d busy?\n", bus->irq);



>-----Original Message-----
>From: Hennerich, Michael
>Sent: Tuesday, April 14, 2009 12:45 PM
>To: 'dmitry.torokhov@...il.com'
>Cc: 'linux-input@...r.kernel.org'; 'linux-kernel@...r.kernel.org';
'Robin Getz'; Hennerich, Michael
>Subject: [PATCH] Input: ad7877.c and ad7879.c: Remove depreciated
IRQF_SAMPLE_RANDOM flag
>
>From: Michael Hennerich <michael.hennerich@...log.com>
>
>This patch removes depreciated IRQF_SAMPLE_RANDOM flags
>from drivers currently queued in Dmitry's input subsystem tree.
>
>Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>
>---
> drivers/input/touchscreen/ad7877.c |    4 ++--
> drivers/input/touchscreen/ad7879.c |    3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/input/joystick/bfin_rotary.c
b/drivers/input/joystick/bfin_rotary.c
>index c318849..7e91bff 100644
>--- a/drivers/input/joystick/bfin_rotary.c
>+++ b/drivers/input/joystick/bfin_rotary.c
>@@ -138,7 +138,7 @@ static int __devinit bfin_rotary_probe(struct
platform_device *pdev)
>                goto out2;
>
>        ret = request_irq(rotary->irq, bfin_rotary_isr,
>-                                IRQF_SAMPLE_RANDOM,
dev_name(&pdev->dev), pdev);
>+                                0 , dev_name(&pdev->dev), pdev);
>        if (ret) {
>                dev_err(&pdev->dev,
>                        "unable to claim irq %d; error %d\n",
>diff --git a/drivers/input/keyboard/adp5588_keys.c
b/drivers/input/keyboard/adp5588_keys.c
>index b424ce4..1da7000 100644
>--- a/drivers/input/keyboard/adp5588_keys.c
>+++ b/drivers/input/keyboard/adp5588_keys.c
>@@ -308,7 +308,7 @@ static int __devinit adp5588_probe(struct
i2c_client *client,
>        }
>
>        ret = request_irq(client->irq, adp5588_irq,
IRQF_TRIGGER_FALLING |
>-               IRQF_SAMPLE_RANDOM | IRQF_DISABLED,
>+               IRQF_DISABLED,
>                client->dev.driver->name, kpad);
>        if (ret) {
>                dev_err(&client->dev, "irq %d busy?\n", client->irq);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/