linux-kernel - Re: [PATCH 0/8] [GIT PULL] TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2009 20:21:00 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Theodore Tso <tytso@....edu>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Hellwig <hch@....de>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Zhaolei <zhaolei@...fujitsu.com>, Li Zefan <lizf@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	"Frank Ch. Eigler" <fche@...stic.org>,
	Tom Zanussi <tzanussi@...il.com>,
	Jiaying Zhang <jiayingz@...gle.com>,
	Michael Rubin <mrubin@...gle.com>,
	Martin Bligh <mbligh@...gle.com>
Subject: Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules


* Steven Rostedt <rostedt@...dmis.org> wrote:

>  include/trace/define_trace.h        |   79 ++++++
>  include/trace/ftrace.h              |  493 +++++++++++++++++++++++++++++++++++
>  include/trace/irq.h                 |   56 ++++-
>  include/trace/irq_event_types.h     |   55 ----
>  include/trace/kmem.h                |  189 +++++++++++++-
>  include/trace/lockdep.h             |   55 ++++-
>  include/trace/lockdep_event_types.h |   57 ----
>  include/trace/sched.h               |  336 +++++++++++++++++++++++-
>  include/trace/sched_event_types.h   |  337 ------------------------
>  include/trace/skb.h                 |   39 +++-
>  include/trace/skb_event_types.h     |   38 ---
>  include/trace/trace_event_types.h   |    7 -
>  include/trace/trace_events.h        |    7 -

Detail: we still have include/trace/kmem_event_types.h around - is 
that intentional? It isnt actually used by anything so we can git-rm 
it.

Also, we mix tracepoint definition headers with other misc headers 
such as syscall.h or boot.h.

I think it would be cleaner and better sructured to have these 
centrally enumerated tracepoint definitions separated in 
include/trace/events/.

That sub-directory would _only_ include the TRACE_EVENT() 
definitions - nothing else. Hence it would also be a nice in-situ 
template collection for anyone adding new tracepoints. The existence 
of other headers really distracts from that.

What do you think?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/