linux-kernel - Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness with hotkeys (BISECTED)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2009 07:51:41 +0200
From:	Niel Lambrechts <niel.lambrechts@...il.com>
To:	Maxim Levitsky <maximlevitsky@...il.com>
CC:	Henrique de Moraes Holschuh <hmh@....eng.br>, mjg59@...f.ucam.org,
	yakui_zhao <yakui.zhao@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux.kernel" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness
 with hotkeys (BISECTED)

On 04/15/2009 02:41 AM, Maxim Levitsky wrote:
> On Wed, 2009-04-15 at 01:59 +0200, Niel Lambrechts wrote:
>   
>> On 04/13/2009 10:34 PM, Henrique de Moraes Holschuh wrote:
>>     
>>> On Mon, 13 Apr 2009, Niel Lambrechts wrote:
>>>   
>>>       
>>>>>> In 2.6.29.1:
>>>>>> lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0
>>>>>> -> ../../devices/virtual/backlight/acpi_video0
>>>>>>         
>>>>>>             
>>> Well, that at least confirms that thinkpad-acpi doesn't have anything to
>>> do with your troubles, you were using acpi video.
>>>   
>>>       
>> Okay, I've bisected it to:
>>
>> 74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit
>> commit 74a365b3f354fafc537efa5867deb7a9fadbfe27
>> Author: Matthew Garrett <mjg59@...f.ucam.org>
>> Date:   Thu Mar 19 21:35:39 2009 +0000
>>
>>     ACPI: Populate DIDL before registering ACPI video device on Intel
>>
>> ---
>>
>> Matthew, can you help?
>>
>> Regards,
>> Niel
>>     
>
>
> Just to note,
>
> I have nvidia, and yet have the same bug.
> I reverted this commit - didn't help.
>   
While you may have _some_ of the same symptoms, you clearly don't have
the same bug.

I reverted the commit as well, and my laptop is working fine under
2.6.30-rc2 now.

> I get lots of 
> ACPI: Failed to switch the brightnes
> when I press hardware keys that change brightness
> (even these sometimes don't work)
>   
Mine consistently did not work, and I had no messages.

I understand you could try to do a limited bisect using something like
git bisect start -- drivers/acpi drivers/video

Perhaps you can do a bisect as well?

Regards,
Niel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/