linux-kernel - Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness with hotkeys (BISECTED)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2009 21:55:55 +0200
From:	Niel Lambrechts <niel.lambrechts@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	Henrique de Moraes Holschuh <hmh@....eng.br>,
	yakui_zhao <yakui.zhao@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux.kernel" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness
 with hotkeys (BISECTED)

On 04/15/2009 06:49 PM, Matthew Garrett wrote:
> Does this help?
>
> diff --git a/drivers/gpu/drm/i915/i915_opregion.c b/drivers/gpu/drm/i915/i915_opregion.c
> index 6942772..8dc1fd3 100644
> --- a/drivers/gpu/drm/i915/i915_opregion.c
> +++ b/drivers/gpu/drm/i915/i915_opregion.c
> @@ -370,11 +370,8 @@ int intel_opregion_init(struct drm_device *dev, int resume
>   
Hi Matthew,

Yes please, after your patch the brightness can be adjusted again. :)

The behaviour seems slightly different from before your 74a365b3f354
commit in that /sys/class/backlight remains empty until i915 gets loaded
for the first time, the contents then persist even if i915 is unloaded.
Perhaps the directory was populated by a different kernel module, since
when I did the bisect yesterday the directory would be there on boot
before I started X or loaded i915.

 I'm not sure if that matters to any other user-space app. (or if
ideally one is supposed to be able to control brightness in the console
without having to load i915), but it's fine for controlling brightness
in Xorg.

Thanks,
Niel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/