linux-kernel - Re: Fix quilt merge error in acpi-cpufreq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2009 00:40:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, hpa@...or.com,
	tglx@...utronix.de, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org, davej@...hat.com
Subject: Re: Fix quilt merge error in acpi-cpufreq.c


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Wed, 15 Apr 2009, Ingo Molnar wrote:
> > 
> > Impact line exposes wrong patch structure: cleanup should never be 
> > mixed with fix.
> >
> > impact line somewhat atypical but correct - the patch is a cleanup 
> > but might affect user-space.
> >
> > Impact line is correct.
> > 
> > Impact line is not duplicative of subject line.
> >
> > Impact line is incorrect (describes action not effect).
> > 
> > Impact line is correct and appropriate.
> 
> Bah. 
> 
> In _no_ case did the Impact: line actually say anything worth 
> saying, and it was there just for self-gratification.

As i said it in the mail, i actually used the impact line of commit 
6b44003e5ca66 ("work_on_cpu(): rewrite it to create a kernel thread 
on demand") later on, when a regression was caused by that commit.

It is the third entry above.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/