linux-kernel - Re: [PATCH 0/2] [GIT PULL] updates for event tester and lockdep tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2009 18:40:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 0/2] [GIT PULL] updates for event tester and lockdep
	tracer


* Steven Rostedt <rostedt@...dmis.org> wrote:

> Ingo,
> 
> I did not add your delay.h fix, since I was not sure if you added 
> it (I saw a commit sha1 in the email).

Forgot to push it out in the big impact-line flamewars^W discussions 
;-)

> I actually wrote the function trace event tester last night. But 
> because it would sometimes lock up the system on bootup I held 
> off.
> 
> But I also found that the lockdep trace points where they are 
> would lock up my system too. If I placed them inside the 
> current->lockdep_recursion, everything ran stable.

Do you think this explains the self-test lockups i reported? The 
lockups happened in the skb test, so i'm unsure. I left the 
workaround (which comments the self-test out) for the time being, 
could you check whether the config i sent works fine for you?

> I ran the lockdep trace points enabled all night with the second 
> patch. Without the second patch, it would lockup within a few 
> minutes.
> 
> Please pull the latest tip/tracing/core-v2 tree, which can be 
> found at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/core-v2
> 
> 
> Steven Rostedt (2):
>       tracing/events: perform function tracing in event selftests
>       tracing/events/lockdep: move tracepoints within recursive protection
> 
> ----
>  kernel/lockdep.c            |   14 ++++----
>  kernel/trace/trace_events.c |   80 +++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 80 insertions(+), 14 deletions(-)

Pulled (from email - i fixed up the conflict with the workaround and 
i added the new-style impact lines), thanks a lot Steve!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/