linux-kernel - Re: Fix quilt merge error in acpi-cpufreq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2009 19:22:09 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	David Miller <davem@...emloft.net>, hpa@...or.com,
	tglx@...utronix.de, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	davej@...hat.com
Subject: Re: Fix quilt merge error in acpi-cpufreq.c

On Thu, 16 Apr 2009, Ingo Molnar wrote:
> 
> Show me one person _you_ actually taught to write good changelogs - 
> just one person who was not a natural born talker to begin with. 
> I'll show you a 100 other people who cannot write good commit logs. 
> They'll try and will limp along, but generally they cannot.
> 
> They might not even have English as their mother tongue - but still 
> can read and understand C fantastically.

So?

The fix for that is not to write crap English. The fix for that is to help 
them, and/or just fix their comments for them.

I really don't see the point of your argument. "People don't always write 
good and complete sentences" is _not_ an argument for then making that a 
standard. 

Just fix things up. Edit their emails. I do. Andrew does. Yes, and despite 
that some commits will still have odd grammar or otherwise not be the 
great novel of the century, and that's not the point. But we should 
_improve_ on the language for people who aren't native English speakers, 
not devolve it to something weaker.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/