lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Apr 2009 07:10:03 +0200 From: Krzysztof Helt <krzysztof.h1@...zta.fm> To: spock@...too.org Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-fbdev-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] fbdev: fix fillrect for 24bpp modes On Sat, 18 Apr 2009 20:52:34 +0200 Michal Januszewski <spock@...too.org> wrote: > The software fillrect routines do not work properly when the number of > pixels per machine word is not an integer. To see that, run the following > command on a fbdev console with a 24bpp video mode, using a non-accelerated > driver such as (u)vesafb: > > reset ; echo -e '\e[41mtest\e[K' > > The expected result is 'test' displayed on a line with red background. > Instead of that, 'test' has a red background, but the rest of the line > (rendered using fillrect()) contains a distored colorful pattern. > > This patch fixes the problem by correctly computing rotation shifts. > It has been tested in a 24bpp mode on 32- and 64-bit little-endian > machines. > > Signed-off-by: MichaĆ Januszewski <spock@...too.org> > --- I have tested the patch and it has worked with padded lines. Acked-by: Krzysztof Helt <krzysztof.h1@...pl> However, there is a comment from Andrew Morton. Regards, Krzysztof ---------------------------------------------------------------------- Gotowka na koncie. Otworz konto direct i wez podwojny limit. http://link.interia.pl/f2115 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists