linux-kernel - Re: linux-next: Tree for April 22: kmemleak: unreferenced object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2009 12:01:29 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Matthias Kaehlcke <matthias@...hlcke.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for April 22: kmemleak: unreferenced object

On Wed, 2009-04-22 at 14:49 +0200, Matthias Kaehlcke wrote:
> shortly after booting next-20090422 on an ep9301, kmemleak complains
> about an unreferenced object:
> 
> kmemleak: unreferenced object 0xc5408610 (size 5):
>   comm "swapper", pid 0, jiffies 4294937323
>   backtrace:
>     [<c00267e0>] save_stack_trace+0x24/0x28
>     [<c00a3db4>] kmemleak_alloc+0x144/0x2cc
>     [<c00a211c>] __kmalloc_node+0x1bc/0x1d4
>     [<c008d730>] kstrdup+0x3c/0x54
>     [<c00bedec>] alloc_vfsmnt+0x9c/0x148
>     [<c00a7c10>] vfs_kern_mount+0x34/0xa8
>     [<c00a7ca4>] kern_mount_data+0x20/0x24
>     [<c0013428>] bdev_cache_init+0x54/0xa0
>     [<c0012c74>] vfs_caches_init+0x104/0x140
>     [<c0008980>] start_kernel+0x244/0x2b8
>     [<00008034>] 0x8034
>     [<ffffffff>] 0xffffffff

That's a known leak happening in bdev_cache_init() - the bd_mnt pointer
is never freed (and people argued that we shouldn't be bothered with
freeing it). I marked it with kmemleak_ignore() but forgot about the
block allocated by kstrdup() in alloc_vfsmnt() and referenced from the
vfsmount structure.

I'll change kmemleak_ignore() to kmemleak_not_leak() so that the
vfsmount structure is scanned for other referenced objects.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/