linux-kernel - Re: [PATCH 7/7] xtensa: add parameter to ccount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2009 12:36:16 +0800
From:	Coly Li <coly.li@...e.de>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH 7/7] xtensa: add parameter to ccount_read()



Johannes Weiner Wrote:
> On Thu, Apr 23, 2009 at 03:12:22AM +0800, Coly Li wrote:
>> This patch modifies parameter of au1x_counter1_read() from 'void' to 'struct
>> clocksource *cs', which fixes compile warning for incompatible parameter type.
> 
> Changelog should be adjusted to say 'ccount_read()' here ;)
> 

Obviously this is a copy+past mistake. I modified the email title, but missed
the changelog :(

>> Signed-off-by: Coly Li <coly.li@...e.de>
>> Cc: Johannes Weiner <hannes@...xchg.org>
>> Cc: Ingo Molnar <mingo@...e.hu>
>> ---
>>  arch/xtensa/kernel/time.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/xtensa/kernel/time.c b/arch/xtensa/kernel/time.c
>> index 8848120..9638641 100644
>> --- a/arch/xtensa/kernel/time.c
>> +++ b/arch/xtensa/kernel/time.c
>> @@ -30,7 +30,7 @@ unsigned long ccount_per_jiffy;		/* per 1/HZ */
>>  unsigned long nsec_per_ccount;		/* nsec per ccount increment */
>>  #endif
>>
>> -static cycle_t ccount_read(void)
>> +static cycle_t ccount_read(struct clocksource *cs)
>>  {
>>  	return (cycle_t)get_ccount();
>>  }
> 
> Thanks.  Copied Chris as well.

Need I resend another patch which fixes the changelog ?

Thanks.
-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/