linux-kernel - Re: [PATCH 1/1] vfs: umount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 25 Apr 2009 00:49:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Alessio Igor Bogani <abogani@...ware.it>,
	Jonathan Corbet <corbet@....net>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	LFSDEV <linux-fsdevel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matthew Wilcox <matthew@....cx>
Subject: Re: [PATCH 1/1] vfs: umount_begin BKL pushdown v2

* Christoph Hellwig <hch@...radead.org> wrote:

> > You've also not explained why you have done it this way. It 
> > would cost you almost nothing to apply these bits into a 
> > separate branch and merge that branch into your main tree. Lots 
> > of other maintainer are doing that.
> 
> Having a separate kill the BKL tree is a stupid idea. Locking 
> changes need deep subsystem knowledge and should always go through 
> the subsystem trees.

Here you are missing the small inconvenient fact that having the 
kill-the-BKL tree is what got this work underway. It is what got 
developers interested, it is what is concentrating the effort, and 
it is that is producing the patches.

_Nobody_ ever suggested that VFS patches should not go upstream via 
the VFS tree. We are _happy_ that BKL removal patches are finally 
flowing through the VFS tree.

The _only_ very minimal courtesy i was asking for was to also be 
'allowed' to carry those fixes that we WROTE, with the same commit 
ID - so that if the kill-the-BKL tree goes upstream sometime in the 
(apparently far) future (well after the VFS bits go upstream), it 
will look nice and wont have duplicate commits. We are patient, and 
we'd like to maintain a tidy tree.

But i didnt even get a _reply_ to that initial request - Al just 
committed it straight into the VFS tree and ignored my question 
somewhat rudely.

The thing is, for years you never cared about the BKL being deep 
embedded in the guts of the VFS. But the minute someone _else_ does 
what arguably you should have done long ago, you stand in the way 
and hinder that effort by first proclaiming that this tree should 
not be doing such changes and then forcing it into an ugly (future) 
rebase?

Exactly how does such kind of behavior help Linux, in your opinion?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/