linux-kernel - Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Apr 2009 13:28:38 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Tim Abbott <tabbott@....EDU>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Anders Kaseorg <andersk@....edu>,
	Waseem Daher <wdaher@....edu>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jeff Arnold <jbarnold@....edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jon Masters <jonathan@...masters.org>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Theodore Ts'o <tytso@....edu>,
	Nikanth Karthikesan <knikanth@...e.de>,
	Arjan van de Ven <arjan@...radead.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Kyle McMartin <kyle@...artin.ca>,
	David Howells <dhowells@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros.

On Sat, Apr 25, 2009 at 10:11:09PM -0400, Tim Abbott wrote:
> This has the consequence of changing the section name use for head
> code from ".text.head" to ".head.text".  Since this commit changes all
> users in the architecture, this change should be harmless.
> 
> Signed-off-by: Tim Abbott <tabbott@....edu>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> ---
>  arch/x86/boot/compressed/Makefile         |    2 +
>  arch/x86/boot/compressed/head_32.S        |    3 +-
>  arch/x86/boot/compressed/head_64.S        |    3 +-
>  arch/x86/boot/compressed/vmlinux_32.lds   |   43 -------------------------
>  arch/x86/boot/compressed/vmlinux_32.lds.S |   45 ++++++++++++++++++++++++++
>  arch/x86/boot/compressed/vmlinux_64.lds   |   48 ---------------------------
>  arch/x86/boot/compressed/vmlinux_64.lds.S |   50 +++++++++++++++++++++++++++++
>  arch/x86/kernel/head_32.S                 |    2 +-
>  arch/x86/kernel/head_64.S                 |    2 +-
>  arch/x86/kernel/vmlinux_32.lds.S          |    4 +-
>  arch/x86/kernel/vmlinux_64.lds.S          |    2 +-
>  11 files changed, 106 insertions(+), 98 deletions(-)
>  delete mode 100644 arch/x86/boot/compressed/vmlinux_32.lds
>  create mode 100644 arch/x86/boot/compressed/vmlinux_32.lds.S
>  delete mode 100644 arch/x86/boot/compressed/vmlinux_64.lds
>  create mode 100644 arch/x86/boot/compressed/vmlinux_64.lds.S


You should split this patch up in smaller pieces.
1) Rename from *lds to *.lds.S (and no other changes)
2) Introduce __HEAD & friends
   And as before do not use HEAD_TEXT_SECTION

But otherwise it looks good. I will take a second look
when new patches are sent.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/