lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 28 Apr 2009 14:24:13 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: Support list_voltage for fixed voltage
 regulator

On Tue, 2009-04-28 at 11:13 +0100, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/regulator/fixed.c |   15 ++++++++++++++-
>  1 files changed, 14 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
> index 6e0bede..4c525af 100644
> --- a/drivers/regulator/fixed.c
> +++ b/drivers/regulator/fixed.c
> @@ -44,10 +44,22 @@ static int fixed_voltage_get_voltage(struct regulator_dev *dev)
>  	return data->microvolts;
>  }
>  
> +static int fixed_voltage_list_voltage(struct regulator_dev *dev,
> +				      unsigned selector)
> +{
> +	struct fixed_voltage_data *data = rdev_get_drvdata(dev);
> +
> +	if (selector != 0)
> +		return -EINVAL;
> +
> +	return data->microvolts;
> +}
> +
>  static struct regulator_ops fixed_voltage_ops = {
>  	.is_enabled = fixed_voltage_is_enabled,
>  	.enable = fixed_voltage_enable,
>  	.get_voltage = fixed_voltage_get_voltage,
> +	.list_voltage = fixed_voltage_list_voltage,
>  };
>  
>  static int regulator_fixed_voltage_probe(struct platform_device *pdev)
> @@ -69,7 +81,8 @@ static int regulator_fixed_voltage_probe(struct platform_device *pdev)
>  	}
>  	drvdata->desc.type = REGULATOR_VOLTAGE;
>  	drvdata->desc.owner = THIS_MODULE;
> -	drvdata->desc.ops = &fixed_voltage_ops,
> +	drvdata->desc.ops = &fixed_voltage_ops;
> +	drvdata->desc.n_voltages = 1;
>  
>  	drvdata->microvolts = config->microvolts;
>  

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ