linux-kernel - Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Apr 2009 12:44:07 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
CC:	axboe@...nel.dk, linux-kernel@...r.kernel.org, joerg@...chain.net,
	geert@...ux-m68k.org, donari75@...il.com, davem@...emloft.net,
	jdike@...ux.intel.com, benh@...nel.crashing.org,
	Laurent@...vier.info
Subject: Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup
 patches

Hello, Bartlomiej.

Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [RFC][PATCH] mg_disk: fix issue with data integrity on error in mg_write()
> 
> We cannot acknowledge the sector write before checking its status
> (which is done on the next loop iteration) and we also need to do
> the final status register check after writing the last sector.
> 
> Fix mg_write() to match mg_write_intr() in this regard.
> 
> While at it:
> - add mg_read_one() and mg_write_one() helpers
> - always use MG_SECTOR_SIZE and remove MG_STORAGE_BUFFER_SIZE
> 
> Cc: unsik Kim <donari75@...il.com>
> Cc: Tejun Heo <tj@...nel.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

I folded other three patches into my series.  This one looks good to me
too but unlike others this one actually changes how the driver
interacts with the device so I think it would be better to wait for
unsik's ack on this one (I'm pushing out others).

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/