linux-kernel - Re: [PATCH 8/9] x86/irq: make MSI irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2009 14:00:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/9] x86/irq: make MSI irq_desc numa aware -v3


* Yinghai Lu <yinghai@...nel.org> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> >> Ingo Molnar wrote:
> >>> * Yinghai Lu <yinghai@...nel.org> wrote:
> >>>
> >>>> +#ifdef CONFIG_NUMA_IRQ_DESC
> >>>> +		/* different node ?*/
> >>>> +		if (desc_new->node != node)
> >>>> +			desc = move_irq_desc(desc, node);
> >>>> +#endif
> >>> this should have been CONFIG_NUMA_MIGRATE_IRQ_DESC. But even with 
> >>> that fixed, CONFIG_NUMA_MIGRATE_IRQ_DESC is _removed_ in the #2 
> >>> patch in your series and never reintroduced!
> >> should change that to CONFIG_SPARSE_IRQ
> > 
> > That's sensible too.
> > 
> 
> do you mean add back CONFIG_NUMA_IRQ_DESC?

No, what i thought to be sensible is to make this behavior part of 
CONFIG_SPARSE_IRQ=y. We dont want a zillion of config options.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/