linux-kernel - Re: [PATCH] SELinux: Remove excessive interrupt disablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2009 15:05:22 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-security-module@...r.kernel.org, jmorris@...ei.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SELinux: Remove excessive interrupt disablement

On 04/29, David Howells wrote:
>
> @@ -2410,9 +2409,9 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
>  	 * wait permission to the new task SID. */
>  	read_lock_irq(&tasklist_lock);

_irq is not needed, just read_lock(&tasklist_lock) should be fine.

>  	psig = current->parent->sighand;
> -	spin_lock_irqsave(&psig->siglock, flags);
> +	spin_lock(&psig->siglock);

I think we don't need ->siglock at all.

>  	wake_up_interruptible(&current->parent->signal->wait_chldexit);

off-topic wrt this patch, but I believe we need

	__wake_up_parent(curremt, current->real_parent);

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/