linux-kernel - Q: about struct task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2009 18:41:15 -0400
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	<linux-kernel@...r.kernel.org>
Subject: Q: about struct task_struct

Hello all,

In struct task_struck, should set_child_tid and clear_child_tid
be int __user * or u32 __user *?

In include/linux/sched.h they are both int __user * but in
kernel/fork.c there is the following line:

	u32 __user * tidptr = tsk->clear_child_tid;

This is causing a sparse warning:

warning: incorrect type in initializer (different signedness)
   expected unsigned int [noderef] [usertype] <asn:1>*tidptr
   got int [noderef] <asn:1>*clear_child_tid

It seems the struct should have them as u32 __user * since the
clone_flags are defined up to 0x80000000 (CLONE_IO).

Thanks,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/