lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Apr 2009 09:06:46 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Hugh Dickins <hugh@...itas.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <balbir@...ux.vnet.ibm.com>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH mmotm] memcg: fix mem_cgroup_update_mapped_file_stat oops On Wed, 29 Apr 2009 22:13:33 +0100 (BST) Hugh Dickins <hugh@...itas.com> wrote: > CONFIG_SPARSEMEM=y CONFIG_CGROUP_MEM_RES_CTLR=y cgroup_disable=memory > bootup is oopsing in mem_cgroup_update_mapped_file_stat(). !SPARSEMEM > is fine because its lookup_page_cgroup() contains an explicit check for > NULL node_page_cgroup, but the SPARSEMEM version was missing a check for > NULL section->page_cgroup. > Ouch, it's curious this bug alive now.. thank you. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> I think this patch itself is sane but.. Balbir, could you see "caller" ? It seems strange. > Signed-off-by: Hugh Dickins <hugh@...itas.com> > --- > Should go in as a fix to > memcg-add-file-based-rss-accounting.patch > but it's curious that's the first thing to suffer from this divergence. > > Perhaps this is the wrong fix, and there should be an explicit > mem_cgroup_disable() check somewhere else; but it would then seem > dangerous that SPARSEMEM and !SPARSEMEM diverge in this way, > and there are lots of lookup_page_cgroup NULL tests around. > > mm/page_cgroup.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- 2.6.30-rc3-mm1/mm/page_cgroup.c 2009-04-29 21:01:06.000000000 +0100 > +++ mmotm/mm/page_cgroup.c 2009-04-29 21:12:04.000000000 +0100 > @@ -99,6 +99,8 @@ struct page_cgroup *lookup_page_cgroup(s > unsigned long pfn = page_to_pfn(page); > struct mem_section *section = __pfn_to_section(pfn); > > + if (!section->page_cgroup) > + return NULL; > return section->page_cgroup + pfn; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists