linux-kernel - RE: [RFC][PATCH 33/35] asm-generic/ptemap.h for HIGHPTE users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 May 2009 11:10:52 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC][PATCH 33/35] asm-generic/ptemap.h for HIGHPTE users

On Fri, 2009-05-01 at 10:51 -0700, Luck, Tony wrote:
> > diff -puN include/asm-generic/ptemap.h~asm-generic-ptemap-h-highpte include/asm-generic/ptemap.h
> > +#ifdef CONFIG_HIGHPTE
> > +#include <asm/highmem.h>
> > +#define pte_offset_map(dir, address) \
> > +     ((pte_t *)kmap_atomic(pmd_page(*(dir)),KM_PTE0) + pte_index(address))
> > +#define pte_offset_map_nested(dir, address) \
> > +     ((pte_t *)kmap_atomic(pmd_page(*(dir)),KM_PTE1) + pte_index(address))
> > +#define pte_unmap(pte) kunmap_atomic(pte, KM_PTE0)
> > +#define pte_unmap_nested(pte) kunmap_atomic((pte), KM_PTE1)
> > +
> > +#else /* !CONFIG_HIGHPTE */
> > +
> > #define pte_offset_map(dir,addr)      pte_offset_kernel((dir),(addr))
> > #define pte_offset_map_nested(dir,addr)       pte_offset_kernel((dir),(addr))
> > #define pte_unmap(pte)                        do { } while (0)
> 
> You need to add a closing #endif here.

Fixed, thanks.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/