linux-kernel - Re: [PATCH 08/10] block: cleanup rq->data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 May 2009 20:27:58 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Boaz Harrosh <bharrosh@...asas.com>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org, jeff@...zik.org,
	linux-ide@...r.kernel.org, linux-scsi@...r.kernel.org,
	bzolnier@...il.com, petkovbb@...glemail.com,
	sshtylyov@...mvista.com, mike.miller@...com,
	chirag.kantharia@...com, Eric.Moore@....com,
	stern@...land.harvard.edu, fujita.tomonori@....ntt.co.jp,
	zaitcev@...hat.com, Geert.Uytterhoeven@...ycom.com,
	sfr@...b.auug.org.au, grant.likely@...retlab.ca,
	paul.clements@...eleye.com, jesper.juhl@...il.com,
	tim@...erelk.net, jeremy@...source.com, adrian@...en.demon.co.uk,
	oakad@...oo.com, dwmw2@...radead.org, schwidefsky@...ibm.com,
	ballabio_dario@....com, davem@...emloft.net, rusty@...tcorp.com.au,
	Markus.Lidel@...dowconnect.com,
	"Darrick J. Wong" <djwong@...ibm.com>
Subject: Re: [PATCH 08/10] block: cleanup rq->data_len usages

On Thu, Apr 30 2009, James Bottomley wrote:
> On Thu, 2009-04-30 at 16:47 +0300, Boaz Harrosh wrote:
> > > @@ -966,7 +965,7 @@ static int scsi_init_sgtable(struct request
> > *req, struct scsi_data_buffer *sdb,
> > >       BUG_ON(count > sdb->table.nents);
> > >       sdb->table.nents = count;
> > >       if (blk_pc_request(req))
> > > -             sdb->length = req->data_len;
> > > +             sdb->length = blk_rq_bytes(req);
> > >       else
> > >               sdb->length = blk_rq_sectors(req) << 9;
> > 
> > Is this true. I thought they must be the same now. I was actually
> > anticipating this if() removed.
> 
> Me too ... there's one of these in scsi_lib.c as well.
> 
> The difference comes because filesystem requests are always in sectors,
> but BLOCK_PC requests are always in bytes .... we should be able to wrap
> the accessors so they do the correct conversions.

blk_rq_bytes() already takes care of this, it can be used on any type
request. So just kill the if/else.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/