linux-kernel - Re: [PATCH] usb: use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 May 2009 19:09:13 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Li Hong <lihong.hi@...il.com>
Cc:	oliver@...kum.name, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: use memdup_user()

Am Sonntag, 3. Mai 2009 18:00:56 schrieb Li Hong:
> Replace a combination call of kmalloc() and copy_from_user() with
> memdup_user().

To be precise. copy_*_user() of course implies that you can do
GFP_KERNEL. But the point is one of design. Right now I can change
locking and if that means that one must use GFP_NOIO, which is common
in usb due to the storage driver, we can find out by simply grepping and
move the user space copy outside of the loop.

If you make that change we must grep against a second and rare
key.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/