lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 May 2009 17:38:06 -0700 (PDT) From: David Rientjes <rientjes@...gle.com> To: "Rafael J. Wysocki" <rjw@...k.pl> cc: Wu Fengguang <fengguang.wu@...el.com>, linux-pm@...ts.linux-foundation.org, Andrew Morton <akpm@...ux-foundation.org>, pavel@....cz, torvalds@...ux-foundation.org, jens.axboe@...cle.com, alan-jenkins@...fmail.co.uk, linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org Subject: Re: [PATCH 1/5] mm: Add __GFP_NO_OOM_KILL flag On Mon, 4 May 2009, Rafael J. Wysocki wrote: > Index: linux-2.6/mm/page_alloc.c > =================================================================== > --- linux-2.6.orig/mm/page_alloc.c > +++ linux-2.6/mm/page_alloc.c > @@ -1620,7 +1620,8 @@ nofail_alloc: > } > > /* The OOM killer will not help higher order allocs so fail */ > - if (order > PAGE_ALLOC_COSTLY_ORDER) { > + if (order > PAGE_ALLOC_COSTLY_ORDER || > + (gfp_mask & __GFP_NO_OOM_KILL)) { > clear_zonelist_oom(zonelist, gfp_mask); > goto nopage; > } This is inconsistent because __GFP_NO_OOM_KILL now implies __GFP_NORETRY (the "goto nopage" above), but only for allocations with __GFP_FS set and __GFP_NORETRY clear. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists