linux-kernel - drivers/scsi/st.c:2967: warning: suggest parentheses around operand of '!' or change '|' to '||' or '!' to '~'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2009 09:51:38 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	scsi <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/scsi/st.c:2967: warning: suggest parentheses around operand 
	of '!' or change '|' to '||' or '!' to '~'

drivers/scsi/st.c:2967: warning: suggest parentheses around operand of
'!' or change '|' to '||' or '!' to '~'

        if (cmdstatp->sense_hdr.sense_key == ILLEGAL_REQUEST &&
            !(STp->use_pf & PF_TESTED)) {
                /* Try the other possible state of Page Format if not
                   already tried */
                STp->use_pf = !STp->use_pf | PF_TESTED;
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                st_release_request(SRpnt);
                SRpnt = NULL;
                return st_int_ioctl(STp, cmd_in, arg);
        }

Looks indeed incorrect to me...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/