linux-kernel - Re: [PATCH] SLQB: Coding style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2009 10:25:45 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SLQB: Coding style cleanups

On Sun, May 03, 2009 at 03:15:10PM +0300, Pekka Enberg wrote:
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> This patch cleans up SQLB to make the code checkpatch clean.

Thanks!

> 
> Cc: Nick Piggin <npiggin@...e.de>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
>  mm/slqb.c |   21 ++++++++++++---------
>  1 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/mm/slqb.c b/mm/slqb.c
> index f538f2c..44a91c0 100644
> --- a/mm/slqb.c
> +++ b/mm/slqb.c
> @@ -59,7 +59,7 @@ static inline void struct_slqb_page_wrong_size(void)
>  /*
>   * slqb_min_order: minimum allocation order for slabs
>   */
> -static int slqb_min_order = 0;
> +static int slqb_min_order;

I actually like explicit zero initializers. I think it has been
a long time since this actually saved any memory with gcc.

Yes yes, I know that anybody who can "read C" will read the
implicit zero initializer anyway... however I just think it is
a stupid thing for checkpatch to warn against.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/