linux-kernel - Re: [patch 7/7] oom: prevent possible OOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 May 2009 11:33:05 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Nick Piggin <npiggin@...e.de>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	San Mehat <san@...roid.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 7/7] oom: prevent possible OOM_DISABLE livelock

On Tue, 5 May 2009, Nick Piggin wrote:

> On Mon, May 04, 2009 at 05:27:07PM -0700, David Rientjes wrote:
> > It is currently possible to livelock the oom killer if a task is chosen
> > for oom kill and another thread sharing the same memory has an oom_adj
> > value of OOM_DISABLE.  This occurs because oom_kill_task() repeatedly
> 
> Hmm, but didn't the last patch make it a per-mm value?
> 

Yes, but this avoids taking task_lock(p) in select_bad_process() and moves 
all locking to badness().  It also introduces new behavior that anything 
with a badness score of 0 won't be killed, which wasn't explicit before 
(we relied on oom_kill_task() to reject it).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/