| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 May 2009 16:57:45 -0700 From: Arve Hjønnevåg <arve@...roid.com> To: Kevin Hilman <khilman@...prootsystems.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs 2009/5/5 Kevin Hilman <khilman@...prootsystems.com>: > Arve Hjønnevåg <arve@...roid.com> writes: > >> On Tue, May 5, 2009 at 8:52 AM, Kevin Hilman > [...] > >> By leaving the interrupt enabled you prevent check_wakeup_irqs from >> aborting suspend. > > Yes, but it doesn't prevent platform-specific code from aborting > suspend. On OMAP, the platform-specific suspend enter hook does a > last check for pending enabled interrupts very late in the sequence. > It seems to me that the platform specific code is the best place to do > this. It will not be pending anymore if the interrupt triggered before all interrupts were masked at the cpu. > On a related note, what happens if your device triggers an interrupt > between check_wakeup_irqs() and the actual suspend? Since it is a > wakeup IRQ, wouldn't you want it to abort the suspend too? > check_wakeup_irqs is called after masking interrupts, so your existing platform specific check should catch it. -- Arve Hjønnevåg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists