linux-kernel - Re: [PATCH] x86 microcode: work_on_cpu and cleanup of the synchronization logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2009 10:08:35 +0200
From:	Dmitry Adamushko <dmitry.adamushko@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Peter Oruba <peter.oruba@....com>,
	Arjan van de Ven <arjan@...radead.org>,
	Hugh Dickins <hugh@...itas.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 microcode: work_on_cpu and cleanup of the 
	synchronization logic

2009/5/7 Dmitry Adamushko <dmitry.adamushko@...il.com>:
> Signed-off-by: Dmitry Adamushko <dmitry.adamushko@...il.com>
> CC: Hugh Dickins <hugh@...itas.com>
> CC: Rusty Russell <rusty@...tcorp.com.au>
> CC: Ingo Molnar <mingo@...e.hu>
> CC: Andreas Herrmann <andreas.herrmann3@....com>
> CC: Peter Oruba <peter.oruba@....com>
> CC: Arjan van de Ven <arjan@...radead.org>
>
>  arch/x86/include/asm/microcode.h  |   19 ++-
>  arch/x86/kernel/microcode_amd.c   |   58 +++-----
>  arch/x86/kernel/microcode_core.c  |  275 ++++++++++++++++++++++---------------
>  arch/x86/kernel/microcode_intel.c |   92 +++++--------
>  4 files changed, 234 insertions(+), 210 deletions(-)
>
> (there are ~20 new comment lines)

My fault, I forgot to remove a minor debuging trick.
The previous patch should be accompanied by the following.

Andreas, any chance you could give it a try with AMD setups? TIA.


(non-white-space-damaged version is enclosed)

--- arch/x86/kernel/microcode_intel-orig.c      2009-05-07
09:57:00.000000000 +0200
+++ arch/x86/kernel/microcode_intel.c   2009-05-07 09:57:47.000000000 +0200
@@ -179,7 +179,7 @@ static inline int update_match_cpu(struc
 static inline int
 update_match_revision(struct microcode_header_intel *mc_header, int rev)
 {
-       return (mc_header->rev < rev) ? 0 : 1;
+       return (mc_header->rev <= rev) ? 0 : 1;
 }

 static int microcode_sanity_check(void *mc)



-- 
Best regards,
Dmitry Adamushko

View attachment "microcode-rework-fix.patch" of type "text/x-patch" (443 bytes)