linux-kernel - Re: [PATCH] Yet another Conexant Clone to add to cdc-acm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 May 2009 00:48:23 +0800
From:	[6][Mee Ew][μ] !!! -- XKJ || mindless :D 
	<xiaokj@...il.com>
To:	Greg KH <gregkh@...e.de>
Cc:	Oliver Neukum <oliver@...kum.name>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Yet another Conexant Clone to add to cdc-acm.c

>> This patch adds another quirky Conexant USB Modem Clone to usb cdc-acm.c
>>
>> This is to be applied to latest git. (Got off the website...)
>>
>> Signed-off-by: Xiao Kaijian <xiaokj@...il.com>
>
> Ah, better, but your email client seems to have eaten all of the tabs
> and spit out spaces instead.  Care to read
> Documentation/email_clients.txt and try it again?
>
>> --- a/drivers/usb/class/cdc-acm.c       2009-05-06 22:06:27.556488116 +0800
>> +++ b/drivers/usb/class/cdc-acm.c       2009-05-06 22:12:56.648401202 +0800
>> @@ -1375,6 +1375,13 @@ static struct usb_device_id acm_ids[] = {
>>        { USB_DEVICE(0x0572, 0x1324), /* Conexant USB MODEM RD02-D400 */
>>        .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
>>        },
>> +       { USB_DEVICE(0x0572, 0x1328), /* Shiro / Aztech USB MODEM UM-3100 */
>> +        .driver_info = NO_UNION_NORMAL, /* has no union descriptor.
>> +                                          This is basically a clone of
>> +                                          Conexant USB MODEM RD02-D400.
>> +                                          Seems like NO_UNION_ _IS_ becoming
>> +                                          NORMAL... */
>
> Is the commentary really needed here?  The majority of devices do not
> need this quirk, so i don't think it's really "normal"...
>
> thanks,
>
> greg k-h

Retry attempt 2: terse mode

I sincerely hope this is finally ok. After much testing on gmail, here it is.
I have verified that it is still applicable to git too.
Thank you for your on-going guidance, even over the huge time zone difference.

***********************
For those uninterested in the personal dialogue above, here it is:
***********************

This patch adds another quirky Conexant USB Modem Clone to usb cdc-acm.c

This is to be applied to latest git. (Got off the website...)

Signed-off-by: Xiao Kaijian <xiaokj@...il.com>

--- a/drivers/usb/class/cdc-acm.c	2009-05-06 22:06:27.556488116 +0800
+++ b/drivers/usb/class/cdc-acm.c	2009-05-06 22:12:56.648401202 +0800
@@ -1375,6 +1375,13 @@ static struct usb_device_id acm_ids[] = {
 	{ USB_DEVICE(0x0572, 0x1324), /* Conexant USB MODEM RD02-D400 */
 	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
 	},
+	{ USB_DEVICE(0x0572, 0x1328), /* Shiro / Aztech USB MODEM UM-3100 */
+	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
+	},
 	{ USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
 	},
 	{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/