linux-kernel - Re: BUG: failure at mm/nommu.c:518/add_nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 May 2009 10:13:33 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	David Howells <dhowells@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: BUG: failure at mm/nommu.c:518/add_nommu_region()

Hi David,

David Howells wrote:
> Can you try the attached patch, please?

Yes, that fixes it :-)

Regards
Greg


> ---
> From: David Howells <dhowells@...hat.com>
> Subject: [PATCH] NOMMU: Don't check vm_region::vm_start is page aligned in add_nommu_region()
> 
> Don't check vm_region::vm_start is page aligned in add_nommu_region() because
> the region may reflect some non-page-aligned mapped file, such as could be
> obtained from RomFS XIP.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  mm/nommu.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index cdc6f60..325706b 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -515,8 +515,6 @@ static void add_nommu_region(struct vm_region *region)
>  
>  	validate_nommu_regions();
>  
> -	BUG_ON(region->vm_start & ~PAGE_MASK);
> -
>  	parent = NULL;
>  	p = &nommu_region_tree.rb_node;
>  	while (*p) {
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/