linux-kernel - Re: [v3][PATCH 5/5] Merge code for single andmultiple-instancemounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2009 16:21:10 -0700
From:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	Eric Paris <eparis@...isplace.org>, Christoph Hellwig <hch@....de>,
	Andrew Morton <akpm@...l.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, serue@...ibm.com,
	hpa@...or.com, sukadev@...ibm.com, linux-kernel@...r.kernel.org,
	jbacik@...hat.com
Subject: Re: [v3][PATCH 5/5] Merge code for single
	andmultiple-instancemounts

| Must be the
| 
| 	memset(&opts, 0, sizeof(opts));
| 
| in devpts_get_sb() (first statement). It should probably set the options to
| default values for cases where 'data' is NULL.
| 
| For now, can you try replacing the memset with:

Er. I meant add following lines after the memset().

|         opts->mode    = DEVPTS_DEFAULT_MODE;
|         opts->ptmxmode = DEVPTS_DEFAULT_PTMX_MODE;
| 
| Sukadev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/